ngMinlength/ngMaxlength broken on input type=number #7967

Activity

1. caitp commented on Jun 24, 2014

   

   caitp

   on Jun 24, 2014

   Contributor

   More actions

   can confirm, @matsko this broke with the changes to the attributes / aliasing, I believe. I'm not sure we ever figured out how we wanted maxlength to work for non-text input types, but maybe it's good enough to just convert the value to a string if it's a number?

   (but yeah, why not use min/max instead of minlength/maxlength for numbers?)
2. caitp commented on Jun 24, 2014

   

   caitp

   on Jun 24, 2014

   Contributor

   More actions

   view value, or stringified model value? I dunno.
3. sijmenvos commented on Jun 24, 2014

   

   sijmenvos

   on Jun 24, 2014

   Author

   More actions

   In my case I need it to be id's that can could also be 0008373 or something, but I see this is not possible because the model value removes the zeroes in front. I'll use a text input with a regex instead in my case.

   The min/max will indeed satisfy for a minimum length of a number (value).

   Thanks for the quick answer.
4. Narretz

   added

   component: forms

   on Jul 15, 2014
5. Narretz

   added this to the 1.3.0This milestone has been deleted milestone on Jul 15, 2014
6. btford

   removed

   gh: issue

   on Aug 20, 2014
7. caitp

   added a commit that references this issue on Aug 28, 2014

   fix(input): validate minlength/maxlength for non-string values

   ...

   This issue will close once commit 7faa60c is merged into the 'master' branch.

   7faa60c
8. caitp

   closed this as completedin 77ce5b8on Aug 29, 2014