This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Number field validation broken #7936
Description
Steps to reproduce: just try to fill non number chars in example at https://docs.angularjs.org/api/ng/input/input%5Bnumber%5D
and check validation result. In myForm.input.$error collection the "number" property is always false.
Activity
VictorQueiroz commentedon Jun 22, 2014
Try type "9.9999999999999999e+23" or type "99999999999999999999999999999999999999999999" and press the up button, and you will see.
stenlee commentedon Jun 22, 2014
I think it should validate as NOT number also NOT Numbers .... ex "abc"
caitp commentedon Jun 22, 2014
you're right, obviously --- I think this is a regression though, either in Chromium or in angular --- because this was definitely working at the time this was checked in
caitp commentedon Jun 22, 2014
I'm looking into it
caitp commentedon Jun 22, 2014
Yeah I think I can write a fix for this quickly, I really, REALLY wish Ian had plotted the constraint validation api better :(
stenlee commentedon Jun 22, 2014
Thank you much Caitlin.
caitp commentedon Jun 22, 2014
I'll see if that changes fixes the docs page once it builds on the CI server, I think it should
caitp commentedon Jun 23, 2014
http://ci.angularjs.org/job/angular.js-caitlin/393/artifact/build/docs/api/ng/input/input%5Bnumber%5D (yes it will still incorrectly report 'required' error --- that is going to take a bit more work to fix, and that's been planned for a while)
fix(input): improve html5 validation support