You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
So this works. Are your refering to a specific behavior? (In beta.12, the behavior changed insofar that invalid model values will show in the bound input regardless of validity.)
@matsko that has always been the case, iirc. The other way round is new (invalid model shows in input). Might actually be a breaking change if you think about it.
Activity
Narretz commentedon Jun 16, 2014
Hm, in this plunker, $error.maxlength becomes true if I have more than 8 characters in the input:
http://plnkr.co/edit/od2qLXAncyy73FAdqlng?p=preview
So this works. Are your refering to a specific behavior? (In beta.12, the behavior changed insofar that invalid model values will show in the bound input regardless of validity.)
matsko commentedon Jun 16, 2014
@Narretz you mean that when the validity is failing then the model value will not show up at all.
http://plnkr.co/edit/it2bJvUwaT3VAy2idGQS?p=preview
Narretz commentedon Jun 16, 2014
@matsko that has always been the case, iirc. The other way round is new (invalid model shows in input). Might actually be a breaking change if you think about it.
matsko commentedon Jun 16, 2014
Yes it could be overly strict. I think we need another property on ngModel that is there no matter what: #6740 (comment)
10 remaining items
tbosch commentedon Aug 4, 2014
Might be fixed via #7968 though...
caitp commentedon Aug 4, 2014
That PR should fix it, but it's a good point that it doesn't really make sense for numbers, in general, but it might be good to support for url/email.
matsko commentedon Aug 4, 2014
The bug is fixed when tested on master: http://plnkr.co/edit/0HKYThxJWZIoHvQIgaol?p=preview
caitp commentedon Aug 4, 2014
the bug is still happening there with the snapshot script, @matsko
matsko commentedon Aug 4, 2014
Sorry, my mistake, I though that we were paying attention to the error and not the model value.
caitp commentedon Aug 8, 2014
well, there's a fix for this but I haven't heard any comments about it =( moving this to the next milestoneeeeee
[-]ngMaxLength with integer only input fails[/-][+]ngMaxLength on type="text" with integer only input fails[/+][-]ngMaxLength on type="text" with integer only input fails[/-][+]ngMaxLength with integer only input fails[/+]Narretz commentedon Sep 24, 2014
As far as I can see the bug in http://plnkr.co/edit/FPYKrOrTrWKf6PnoaYro?p=preview is fixed in the current snapshot.