form and input is getting dirty by clicking on a simple button #7457

Activity

1. caitp commented on May 14, 2014

   

   caitp

   on May 14, 2014

   Contributor

   More actions

   http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#attr-button-type

   The type attribute controls the behavior of the button when it is activated. It is an enumerated attribute. The following table lists the keywords and states for the attribute — the keywords in the left column map to the states in the cell in the second column on the same row as the keyword.

   Keyword	State	Brief description
   submit	Submit Button	Submits the form.
   reset	Reset Button	Resets the form.
   button	Button	Does nothing.
   menu	Menu	Shows a menu.

   The missing value default is the Submit Button state.

   If the type attribute is in the Submit Button state, the element is specifically a submit button.

   Basically, when you don't give your button a type, it defaults to "submit", and angular's submission handler causes the form to be dirty'd.

   You have an easy work around, just give the button a type, like type="button", that should prevent form submission and avoid dirtying the form/model controllers.

   @petebacondarwin / @matsko should we be dirtying the form on submit if it doesn't change? that seems weird.
2. caitp

   added

   severity: confusing

   and removed

   resolution: works as expected

   on May 14, 2014
3. caitp

   added this to the 1.3.0This milestone has been deleted milestone on May 15, 2014
4. westor21 commented on May 15, 2014

   

   westor21

   on May 15, 2014

   Author

   More actions

   Thank you for your answer. And yes, that seems to be not the expected behaviour to me. We are setting classes in dependence a form element is touched by the user. Therefore it seems to be weird to set the form and the elements dirty if nothing was edited.
5. caitp

   self-assigned this

   on May 15, 2014
6. shahata commented on May 16, 2014

   

   shahata

   on May 16, 2014

   Contributor

   More actions

   @caitp @petebacondarwin the form is becoming dirty due my bug in a0ae07b ($commitViewValue always sets the control as dirty and now it is called with every submit). I'll take a look into this.
7. petebacondarwin commented on May 16, 2014

   

   petebacondarwin

   on May 16, 2014

   Contributor

   More actions

   Thanks @shahata
8. petebacondarwin

   closed this as completedin facd904on May 18, 2014
9. RichardLitt

   added a commit that references this issue on May 24, 2014

   fix(ngModel): do not dirty the input on $commitViewValue if nothing w…

   ...

   This issue will close once commit f439c0a is merged into the 'master' branch.

   f439c0a
10. NaomiN commented on Sep 20, 2017

    

    NaomiN

    on Sep 20, 2017

    More actions

    I am using angular-js 1.6.4 and I am getting the same problem. May be the issue re-appeared. I fixed it by setting my buttons type to be button instead of submit, but the issue marked as closed so I should not need to have done it, right?
11. NaomiN

    unassigned

    caitp

    on Sep 20, 2017
12. petebacondarwin commented on Sep 20, 2017

    

    petebacondarwin

    on Sep 20, 2017

    Contributor

    More actions

    @NaomiN the original issue is not broken with 1.6.4. See http://plnkr.co/edit/EAAdJScYtRJKich5FJQs?p=preview

    If you are experiencing a different issue then please can you create a new issue with a reproduction.
13. NaomiN commented on Sep 20, 2017

    

    NaomiN

    on Sep 20, 2017

    Last edited by NaomiN

    More actions

    In the original plunker I made a single change - the input type="number" to demonstrate the problem. The problem only shows for input type="number" and buttons. I made a google search and found this issue. So my solution was to use button type="button"
14. petebacondarwin commented on Sep 20, 2017

    

    petebacondarwin

    on Sep 20, 2017

    Contributor

    More actions

    I just tried that on my new plunker and it still doesn't mark it as dirty.
15. NaomiN commented on Sep 20, 2017

    

    NaomiN

    on Sep 20, 2017

    More actions

    Weird, I can no longer reproduce myself there even though it marked as dirty this morning. I know I spent several hours last night trying to figure out the problem with my form before landing on this issue.