This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Improve support for collections in ngModelController #7203
Description
Writing directives to handle input of collections (lists or objects) is currently not very well supported because ngModelController uses identity tests to determine if the model or view value changes.
Adding a collection watch mode to ngModelController would allow for more robust input directives such as checkbox lists to work without having to do things like creating new lists on every update or monkey patching the ngModelController instance.
This issue has come up a few times, but the only place I could find it yesterday was in #2553, which is closed.
Activity
groner commentedon Apr 22, 2014
I'm considering writing a patch for this, but I'd like some input on the API.
Possibilities I've considered and rejected are:
model.$watcher = function() { ... }, doesn't address the comparisons that happen outside of the watcher function.model.$isEqual = function(curr, prev) { ... }requires copying lists and objects for later comparison, we may as well just usescope.$watchCollection().model.$collectionMode = trueis pretty simple and it could be observed insidengModelWatch()and$setViewValue(), but I think we wantscope.$watchCollection().So I think the API that would work is
model.$collectionMode(true).This still feels a bit funny to me because the watch has already started by the time we're calling it so the $collectionMode function has to undo the initial watch and start a collection watch. Maybe moving the watch to the linking function and adjusting priority could work around this? I guess I could try it and see what breaks.
Narretz commentedon Sep 9, 2014
In #5449 @petebacondarwin suggested to use the modelEquality parameter for $watch.
Narretz commentedon Dec 10, 2014
Let's track this here: #5449