Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngOptions : regression 1.2.15 && 1.3.0-beta.3 #6828

Closed
#8106
Closed
ngOptions : regression 1.2.15 && 1.3.0-beta.3#6828
#8106
Assignees
IgorMinar
Labels
PRs plz!component: formsfrequency: highseverity: regressiontype: bug
Milestone
1.3.0-beta.15

Description

@GabrielDelepine
GabrielDelepine
opened on Mar 25, 2014

When the select tag has the required attribute, the default blank option is ignore.

1.2.14 works
1.2.15 doesn't
1.3.0-beta.3 doesn't

See the jsfiddle

Activity

  1. lefos987
    added
    component: forms
    on Mar 25, 2014

  2. Narretz commented on Mar 25, 2014

    @Narretz
    Narretz
    on Mar 25, 2014
    Contributor

    I can't reproduce this in FF 28. 1.2.14 / 1.2.15 look the same. Which browser did you test? There was a fix for a Firefox ngOptions render bug, maybe this is related. f40f54c

  3. GabrielDelepine commented on Mar 25, 2014

    @GabrielDelepine
    GabrielDelepine
    on Mar 25, 2014
    Author

    Sorry, I forgot to mention this.

    Chrome 30 : bug
    Chromium 32 : bug
    Firefox 27 : no bug

  4. caitp commented on Mar 25, 2014

    @caitp
    caitp
    on Mar 25, 2014
    Contributor

    WFM in Chrome stable

  5. GabrielDelepine commented on Mar 25, 2014

    @GabrielDelepine
    GabrielDelepine
    on Mar 25, 2014
    Author

    I just update to Chromium 33 and I still have the issue.

  6. caitp commented on Mar 25, 2014

    @caitp
    caitp
    on Mar 25, 2014
    Contributor

    Do you have all your extensions disabled when testing?

  7. GabrielDelepine commented on Mar 25, 2014

    @GabrielDelepine
    GabrielDelepine
    on Mar 25, 2014
    Author

    @caitp Yes, all extensions disabled and with the incognito mode of chrome. My OS is Ubuntu.
    Chromium = Ubuntu repo
    Chrome = Google repo

    I also tried with Chrome under W7 (fresh install) and this bug also ! See this screenshot

    IE11 doesn't bug

  8. caitp commented on Mar 25, 2014

    @caitp
    caitp
    on Mar 25, 2014
    Contributor

    I can't reproduce on OSX 10.9 or Windows 8.1 with Chrome 33. You should investigate it, but it's possibly a browser bug.

  9. lgalfaso commented on Mar 25, 2014

    @lgalfaso
    lgalfaso
    on Mar 25, 2014
    Contributor

    @yappli I am able to reproduce this with Chrome 33 and OSX 10.9 and it does look like a browser bug.
    The easiest workaround I was able to find is to change the attribute require to ng-required="true"

  10. GabrielDelepine commented on Mar 25, 2014

    @GabrielDelepine
    GabrielDelepine
    on Mar 25, 2014
    Author

    @lgalfaso : Your workaround works for me, thanks.

    I don't know if it's a browser bug or not. Probably.

  11. caitp commented on Mar 25, 2014

    @caitp
    caitp
    on Mar 25, 2014
    Contributor

    The reason I couldn't reproduce it is because you posted an example of the working build, not of the broken build. This is bad, don't do this, it's not helpful. Especially on jsfiddle where the UI doesn't make it obvious that you're using the working build!

    So yes, there is a regression from the fix to break the problem in Firefox. Someone should look into this, PRs welcome, although I suppose there is a workaround to fix this.

  12. caitp
    added
    PRs plz!
    on Mar 25, 2014

  13. 26 remaining items

  14. caguillen214
    modified the milestones: 1.3.0-beta.15, 1.3.0-beta.14 on Jun 30, 2014
  15. lgalfaso
    added a commit that references this issue on Jul 8, 2014

    fix(select): auto-select new option that is marked as selected

    8bc2667
  16. lgalfaso
    closed this as completedin 8bc2667on Jul 8, 2014
  17. lgalfaso
    added 2 commits that reference this issue on Jul 8, 2014

    fix(select): auto-select new option that is marked as selected

    777870d

    fix(select): auto-select new option that is marked as selected

    b8ae73e