input[type="date"] min/max as date objects #6754

Activity

1. caitp commented on Mar 19, 2014

   

   caitp

   on Mar 19, 2014

   Contributor

   More actions

   This sort of thing has come up before, with regards for ng-true-value (among others) for checkboxes/etc. When using a single attribute, you don't want it to sometimes be a constant string, and sometimes a value to be parsed.

   I don't necessarily think it's a problem to use a parsed value, particularly for dates, because I think it's unlikely people want to write out a constant date in their markup.

   It may not be too late to change this API, I'm not sure. What do you think @tbosch, is that worthwhile? String-format dates could still be supported via min="'03/17/1988'" or something
2. scottopherson commented on Mar 19, 2014

   

   scottopherson

   on Mar 19, 2014

   Author

   More actions

   Yeah, I think it's fine to just use strings. I only brought it up because initially I had assumed that using date objects for min/max would work. After a couple minutes of trying to figure out why my example wasn't working, it wasn't until I took a closer look at the documentation that I realized my assumption was incorrect.
3. lefos987

   added

   component: forms

   on Mar 20, 2014
4. lefos987

   added this to the BacklogThis milestone has been deleted milestone on Mar 20, 2014
5. btford

   removed

   gh: issue

   on Aug 20, 2014
6. tkrotoff commented on Jun 17, 2015

   

   tkrotoff

   on Jun 17, 2015

   More actions

   +1, I have to write this:

   <input type="date"
          ng-model="start"
          max="{{end != undefined ? end : '9999-01-01' | date: 'yyyy-MM-dd'}}">
   
   <input type="date"
          ng-model="end"
          min="{{start != undefined ? start : '0001-01-01' | date: 'yyyy-MM-dd'}}">

   This way it is compliant with Chrome datepicker: the user cannot select a date before/after min/max.

   I would have expected to write:

   <input type="date"
          ng-model="start"
          ng-max="end">
   
   <input type="date"
          ng-model="end"
          ng-min="start">

   with ng-min/max taking care of generating min/max attributes if the date is not undefined or null.

   Same for <input type="time">, <input type="datetime-local">...