Async form validation #6416

Activity

1. pkozlowski-opensource commented on Feb 23, 2014

   

   pkozlowski-opensource

   on Feb 23, 2014

   Member

   More actions

   Hmm, I'm pretty sure I saw already an issue opened for this, can't find it atm, though...
2. frederikcreemers commented on Feb 23, 2014

   

   frederikcreemers

   on Feb 23, 2014

   ContributorAuthor

   More actions

   Maybe you're thinking about my topic in angular-dev? I posted about this a
   while ago, but never got to implement it.

   I searched for it, but couldn't find it.

   2014-02-23 17:54 GMT+01:00 Pawel Kozlowski [email protected]:

   Hmm, I'm pretty sure I saw already an issue opened for this, can't find it
   atm, though...

   Reply to this email directly or view it on GitHubhttps://github.com//issues/6416#issuecomment-35836209
   .
3. btford

   self-assigned this

   on Feb 26, 2014
4. btford

   added

   type: feature

   on Feb 26, 2014
5. btford

   added this to the Ice Box milestone on Feb 26, 2014
6. IgorMinar

   modified the milestones: Ice Box, 1.3.0This milestone has been deleted on Jul 29, 2014
7. btford

   removed

   gh: issue

   on Aug 20, 2014
8. btford commented on Aug 28, 2014

   

   btford

   on Aug 28, 2014

   Contributor

   More actions

   This landed in the commits in the #8267 PR. Closing.
9. btford

   closed this as completedon Aug 28, 2014
10. nikoudel commented on May 20, 2015

    

    nikoudel

    on May 20, 2015

    More actions

    $asyncValidators don't solve the problem described in this issue. They only mark the input as valid/invalid but they don't modify $viewValue (example). Maybe this issue should be re-opened?
11. jsdevel commented on Jan 1, 2016

    

    jsdevel

    on Jan 1, 2016

    Contributor

    More actions

    Check out https://github.com/kogosoftwarellc/angular-async-form. I believe it solves the real issue quite nicely.

    The real shortcoming is that the current angular API really only handles validation up until the user submits a form. Validation errors coming back after the user submitted the form have almost been entirely ignored. That's what angular-async-form aims to solve.

    Here's a quick example of how it is used in a form:

    <!DOCTYPE html>
    <html ng-app="myApp">
      <head>
        <style>
        .error {color: red;}
        </style>
      </head>
      <body ng-controller="AppCtrl">
        <h1>Hello {{ user.firstName }}!</h1>
    
        <form af-submit="doSomething($event, cb)" novalidate>
          <div class="error" af-message>{{ message }}</div>
          <div class="control-group" af-control-group>
            <div class="error" af-control-message>{{ error }}</div>
    
            <input
              name="firstName"
              ng-model="user.firstName"
              af-control
              required>
            <button type="submit">Submit</button>
          </div>
        </form>
    
        <script src="https://code.angularjs.org/1.4.8/angular.js"></script>
        <script src="angular-async-form.js"></script>
        <script src="app.js"></script>
      </body>
    </html>

    In your doSomething handler, you can call the cb with a form wide error message, or error messages isolated to controls (which invalidate the form for subsequent submissions). Users must blur controls with server side validation errors before the form may be submitted again.