This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
regression: ngHref - #6273
Description
This commit (f3de5b6) caused an old e2e test to fail (See angular/dgeni#44).
See https://github.com/angular/angular.js/blob/master/src/ng/directive/booleanAttrs.js#L72
<a id="link-4" href="" name="xx" ng-click="value = 4">anchor</a> (link, don't reload)<br />
it('should execute ng-click but not reload when href empty string and name specified', function() {
element(by.id('link-4')).click();
expect(element(by.model('value')).getAttribute('value')).toEqual('4');
expect(element(by.id('link-4')).getAttribute('href')).toBe('');
});
Previously, if you had a name but no href it would still prevent the click from propagating. The performance refactor commit, referenced above, changed the a directive so that if there is neither href or name then the click will propagate and so clicking the link would cause the page to reload.
We need to decide if this previous functionality is important and if so modify the a directive accordingly and potentially re-activate the protractor test that was broken. If not, then we should just remove the failing protractor test altogether.
FAO: @IgorMinar and @kseamon
Activity
34 remaining items
fix(a): don't reload if there is only a name attribute
fix(a): don't reload if there is only a name attribute