ng-required conflicts with ng-true-value #5164

Activity

1. ghost assigned

   matsko

   on Dec 31, 2013
2. matsko commented on May 7, 2014

   

   matsko

   on May 7, 2014

   Contributor

   More actions

   This should fix the issue: #7377
3. matsko

   added 2 commits that reference this issue on May 27, 2014

   fix(NgModel): make sure the required validator uses the $validators p…

   ...

   This issue will close once commit 7df9181 is merged into the 'master' branch.

   7df9181

   fix(NgModel): make sure the required validator uses the $validators p…

   ...

   This issue will close once commit 154ee61 is merged into the 'master' branch.

   154ee61
4. matsko

   added 3 commits that reference this issue on Jun 10, 2014

   fix(NgModel): make sure the required validator uses the $validators p…

   ...

   This issue will close once commit 7c7da3a is merged into the 'master' branch.

   7c7da3a

   fix(NgModel): make sure the required validator uses the $validators p…

   ...

   This issue will close once commit 960d32b is merged into the 'master' branch.

   960d32b

   fix(NgModel): make sure the required validator uses the $validators p…

   ...

   This issue will close once commit c07d7ba is merged into the 'master' branch.

   c07d7ba
5. matsko

   closed this as completedin e53554aon Jun 13, 2014
6. tbosch commented on Aug 4, 2014

   

   tbosch

   on Aug 4, 2014

   Contributor

   More actions

   This is still not working, see this punker with current 1.3.x version (http://plnkr.co/edit/VUAVYLLchaq5bNwgseRp?p=preview)

   • unchecking any checkbox (with and without ng-true-value) results in the model to be set to undefined. However: An invalid input should not update the model at all!
   • the second checkbox which has an ng-true-value shows an required error on load although it is checked. Unchecking it resets the model as well (which is already wrong), but checking it again does not set the model value to the ng-true-value back.
7. tbosch

   reopened this on Aug 4, 2014
8. matsko commented on Aug 4, 2014

   

   matsko

   on Aug 4, 2014

   Contributor

   More actions

   I'll work on this today.
9. btford

   removed

   gh: issue

   on Aug 20, 2014
10. Narretz commented on Sep 7, 2014

    

    Narretz

    on Sep 7, 2014

    Contributor

    More actions

    This still happens. The problem is that $isEmpty is called with the viewValue, and checkboxInputType's $isEmpty returns true when the viewValue is unequal to the trueValue, which will almost always be the case.
11. Narretz commented on Sep 7, 2014

    

    Narretz

    on Sep 7, 2014

    Contributor

    More actions

    I have a fix for this. Will send PR later.
12. Narretz

    assigned

    Narretz

    and unassigned

    matsko

    on Sep 7, 2014
13. Narretz

    added 4 commits that reference this issue on Sep 8, 2014

    fix(input): make checkbox ngTrueValue work with required

    ...

    This issue will close once commit d6d775f is merged into the 'master' branch.

    d6d775f

    fix(input): make checkbox ngTrueValue work with required

    ...

    This issue will close once commit 0bd4f6e is merged into the 'master' branch.

    0bd4f6e

    fix(input): set ngTrueValue on required checkbox

    ...

    This issue will close once commit 1d47b0b is merged into the 'master' branch.

    1d47b0b

    fix(input): set ngTrueValue on required checkbox

    ...

    This issue will close once commit ad86241 is merged into the 'master' branch.

    ad86241
14. tbosch

    added a commit that references this issue on Sep 10, 2014

    fix(input): always pass in the model value to `ctrl.$isEmpty`

    ...

    This issue will close once commit fb9b667 is merged into the 'master' branch.

    fb9b667
15. tbosch

    closed this as completedin 3e51b84on Sep 10, 2014
16. petebacondarwin

    added 3 commits that reference this issue on Nov 21, 2014

    fix(input): set ngTrueValue on required checkbox

    ...

    This issue will close once commit c3ee664 is merged into the 'master' branch.

    c3ee664

    fix(input): set ngTrueValue on required checkbox

    ...

    This issue will close once commit 187654c is merged into the 'master' branch.

    187654c

    fix(input): set ngTrueValue on required checkbox

    ...

    This issue will close once commit 8692f87 is merged into the 'master' branch.

    8692f87