This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Form submit prevention changes #3370
Description
Right now the condition is
if (!attr.action) {
// prevent submit
}(https://github.com/angular/angular.js/blob/master/src/ng/directive/form.js#L310)
This breaks lots of existing forms with action="", which is useful when sending POST to the same page. In current situation, to fix this, we need to change our templates to something like action="<? $_SERVER['PHP_SELF'] ?>".
I suggest changing the condition to
if (!attr.action && attr.action !== '') {
// prevent submit
}Does this make any sense?
Activity
IgorMinar commentedon Aug 28, 2013
yes. I think this is valid issue. falsy-ness check is not sufficient here as
action=""still gets "prevented".drkwolf commentedon Sep 10, 2013
why is it not yet merged ?
thebigredgeek commentedon Sep 27, 2013
@drkwolf , just build the PR branch locally in the mean time with changes merged in from master
robjames commentedon Feb 10, 2014
+1
totof3110 commentedon Sep 13, 2014
Just got bitten by this bug. If the action attribute is a substitution based on a variable read asynchronously (Ajax) this seems to also happen:
=> when
someObjectis the result of an Ajax call, Angular seems to initialize the action tag as an empty string and then prevent default form submit, even after the action is populated.