This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Sample AngularHint application? #36
Description
@btford Besides the contrived examples in the e2e tests, we had discussed having a more realistic sample application using AngularHint to demonstrate its functionality. Would this sample application be developed in this repository? Do we have any ideas of what sort of application it should be like?
Metadata
Metadata
Assignees
Labels
No labels
Activity
feat(example): create "Angular Best Practices" example app to show of…
ealtenho commentedon Aug 6, 2014
@caguillen214, I've created an example app that is meant to look somewhat correct although underneath it violates many best practices in order to showcase how silent errors affect applications. Please feel free to add to the errors in the application or change it as necessary. I know that many of the errors in
HintDirectivescorrespond to custom directives, but I wasn't sure if it was overkill to create a custom directive for this simple application. What do you think? I'm also considering making a second application with identical look and feel and goal, but that does not violate the best practices.ealtenho commentedon Aug 6, 2014
In 17ed6ae I've added a
correctExamplethat has the same behavior as theexamplebut does not violate best practices. It should not produce any error messages. However, some problems in individual modules cause incorrect hints. I've filed issues on those modules: https://github.com/angular/angular-hint-dom/issues/14, https://github.com/angular/angular-hint-modules/issues/14, https://github.com/angular/angular-hint-controllers/issues/10caguillen214 commentedon Aug 6, 2014
This is great! And I think thats a good idea. I do think that making custom directives would be beneficial though because theres a lot of features related to that in
HintDirectivesealtenho commentedon Aug 7, 2014
Okay, I've basically spent today fixing the issues I referenced above that I discovered in testing the SampleApplication. I will work on adding a custom directive to test and show AngularHintDirectives behavior.
feat(sampleApps): add directive examples to sample applications
ealtenho commentedon Aug 7, 2014
In 149b9b5 I updated the incorrect example app and the correctExample app to use a custom directive. Honestly, I'm not sure I'm familiar enough with directives to make a really convincing broken example. Feel free to suggest changes. I've tried to maximize the number of hints that I am generating.