Skip to content

docs: No more cache clean on NPM 5#7437

Closed
code1line wants to merge 3 commits intoangular:masterfrom
code1line:patch-2
Closed

docs: No more cache clean on NPM 5#7437
code1line wants to merge 3 commits intoangular:masterfrom
code1line:patch-2

Conversation

@code1line
Copy link
Copy Markdown

@code1line code1line commented Aug 19, 2017

npm cache verify is possible, but not necessary.

@code1line
Copy link
Copy Markdown
Author

code1line commented Aug 19, 2017

Please also change the line in the README.md.

@code1line code1line changed the title No more cache clean on NPM 5 docs: No more cache clean on NPM 5 Aug 19, 2017
@hansl
Copy link
Copy Markdown
Contributor

hansl commented Aug 20, 2017 •
edited
Loading

Hi @code1line, this PR looks good, but we have strict policy with the commit conventions (see CONTRIBUTING.md). Could you amend your commit (use git commit --amend && git push -f) to change the message to docs: cache clean is not needed on NPM 5 (or similar)? Thanks.

(nota: the PR title is right, but we only care about the commits themselves since those are the ones making it to master)

@code1line
Copy link
Copy Markdown
Author

code1line commented Aug 21, 2017

Done!

filipesilva
filipesilva reviewed Sep 5, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, thanks for updating this doc as well. The problem with the commit messages is the same as in your other PR (#7436). I left some instructions there on how you can squash the commits.

@filipesilva filipesilva self-assigned this Sep 5, 2017
@devoto13 devoto13 mentioned this pull request Sep 5, 2017
Closed
@filipesilva filipesilva mentioned this pull request Sep 27, 2017
Closed
@hansl
Copy link
Copy Markdown
Contributor

hansl commented Feb 8, 2018

We're removing support for npm 3 so this is moot.

@hansl hansl closed this Feb 8, 2018
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@filipesilva filipesilva filipesilva left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@code1line @hansl @filipesilva @googlebot