Skip to content

docs: Changed sass-test-variable - $brand-primary#7436

Closed
code1line wants to merge 7 commits intoangular:masterfrom
code1line:patch-1
Closed

docs: Changed sass-test-variable - $brand-primary#7436
code1line wants to merge 7 commits intoangular:masterfrom
code1line:patch-1

Conversation

@code1line
Copy link
Copy Markdown

$brand-primary is no longer available. Instead of setting the whole schema $theme-colors(...), the blue-part is set to red.

$brand-primary is no longer available. Instead of setting the whole schema $theme-colors(...), the blue-part is set to red.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@code1line
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@code1line code1line changed the title Change sass-test-variable - $brand-primary docs: Change sass-test-variable - $brand-primary Aug 19, 2017
$brand-primary is no longer available. Instead of setting the whole schema $theme-colors(...), the blue-part is set to red.
@code1line code1line changed the title docs: Change sass-test-variable - $brand-primary docs: Changed sass-test-variable - $brand-primary Aug 21, 2017
Copy link
Copy Markdown
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, thanks for making this change. CI is failing because of the commit names, can you squash them into a single commit named docs: changed sass-test-variable - $brand-primary ?

You can do this with git rebase -i, renaming the first commit and marking the others as fixup.

$brand-primary is no longer available. Instead of setting the whole schema $theme-colors(...), the blue-part is set to red. (+1 squashed commit)
Squashed commits:
[682aa1d] docs: changed sass-test-variable - $brand-primary

$brand-primary is no longer available. Instead of setting the whole schema $theme-colors(...), the blue-part is set to red.
@hansl
Copy link
Copy Markdown
Contributor

hansl commented Feb 22, 2018

Closing this as this has been updated in master already. Thanks!

@hansl hansl closed this Feb 22, 2018
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants