feat(broccoli): add jade render - #626
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Jade was renamed to pug, the transition is in progress, but I think the word |
|
Hi. Thanks @t-fox! Could you add tests? You can base those on the CSS ones. Also, seems like linting was failing. Please fix and rebase :) |
|
|
||
| options = options || {}; | ||
| Plugin.call(this, inputNodes, { | ||
| cacheInclude: [/\.jade/] |
There was a problem hiding this comment.
Shouldn't this be /\.jade$/ (with a $ at the end) ?
a88b606 to
82233e3
Compare
|
OK, @hansl. Added test and rebased. ;) It also uses pug instead of jade. |
|
@t-fox can you add some instructions to the readme regarding how to use this functionality? |
| The `Angular2App`'s options argument has `sassCompiler`, `lessCompiler`, `stylusCompiler` and `compassCompiler` options that are passed directly to their respective CSS preprocessors. | ||
|
|
||
| ### Additional Support | ||
| - pug (pug) |
There was a problem hiding this comment.
What does this section mean?
|
@filipesilva I updated readme and rebased |
|
What about generate code with |
|
@krasevych Isn't it obvious? Nonetheless I updated Readme. |
|
+1 for this |
| }); | ||
| }); | ||
|
|
||
| it.skip('Installs pug support successfully', function() { |
There was a problem hiding this comment.
Other tests like sass support are skipped too since 7c0ba39
|
Besides updating, what's missing for the release of this? |
|
Has this been included? |
|
It's still marked as a work in progress. I feel I'm still too green to contribute, but I could help out with what's missing, if original contributors can't. |
|
@filipesilva can this issue be revived? |
|
@filipesilva since the webpack branch is merged now, is there a plan to add a pug/jade loader, just like there is already a sass/less/stylus loader? It would be awesome if we could just write: |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.