update wiki Bootstrap story #5239 - #5248
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| "styles.css" | ||
| ], | ||
| ``` | ||
|
|
| "../node_modules/tether/dist/js/tether.js", | ||
| "../node_modules/bootstrap/dist/js/bootstrap.js", | ||
| ] | ||
|
|
There was a problem hiding this comment.
My first wiki pull apperently. Will try again. Thanks for your help.
| to see which versions of jQuery are supported. | ||
| https://v4-alpha.getbootstrap.com/getting-started/javascript/ | ||
|
|
||
| ``json |
|
There's another section at the bottom that references Thanks! |
|
If this is included, a note pointing to some of the angular bootstrap projects should also be included. As they would be most likely preferred by many users. |
|
These are individual projects/component that have anything todo with the setup of Angular-cli. |
|
Those are alternatives to the bootstrap javascript that provide angular friendly directives/components. |
|
I tend to agree with @clydin that most people will prefer one of the Angular specific implementations of bootstrap's components. If this is a route that you would like to go down, I would suggest creating a new story
That covers these 3 scenarios:
Then link to this story as part of the existing bootstrap setup story. |
|
I've been thinking about this a little more... I'm OK with adding JS-based logic to this document directly, but I still feel strongly that we should present all 3 options mentioned above. The point of this document is providing a way for people to setup Bootstrap, not to be opinionated about the means in which they set it up. Can you please add implementation instructions for the other two options? As well as a brief paragraph above the 3 explaining what the options are in an unbiased manner? |
|
The question was to add a note about how to include the basic Bootstrap JS, because Bootstrap would not always work as aspected. In case of https://ng-bootstrap.github.io, you still need to add the css but not the JS files (but I have them both and seems to work). In the whole it becoming more complicated than the original remarks. |
|
@Brocco can you re-review please? |
Brocco
left a comment
There was a problem hiding this comment.
I have a few comments and wanted to mention that this will also need rebased.
| - ng bootstrap https://ng-bootstrap.github.io (version 4.x only) | ||
| - ng2 bootstrap http://valor-software.com/ng2-bootstrap/ (version 3.x & 4.x) | ||
|
|
||
| You should check with the libraries for instructions how to include their project with Angular-cli. You probably only need to |
There was a problem hiding this comment.
If you're not going to provide specific instructions for each of these solutions, please remove this line and leave just the links.
|
|
||
| # version 4.x | ||
| "scripts": [ | ||
| "../node_modules/jquery/dist/jquery.js", |
There was a problem hiding this comment.
Please make the spacing consistent (this is a minor nit-pick, but I've also requested other changes 😀)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix #5239