Skip to content

feature: Adds public folder - #363

Closed
cwramsey wants to merge 1 commit into
angular:masterfrom
cwramsey:master
Closed

feature: Adds public folder#363
cwramsey wants to merge 1 commit into
angular:masterfrom
cwramsey:master

Conversation

@cwramsey

Copy link
Copy Markdown
Contributor

All this does is add a folder and a placeholder file that can be deleted. I'm not familiar enough with ember cli yet to delete the .placeholder file after the files have been moved, but this is a start.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@cwramsey

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@hansl hansl added command: new feature Label used to distinguish feature request from other issues and removed type: enhancement labels Mar 29, 2016
@hansl

hansl commented Mar 29, 2016

Copy link
Copy Markdown
Contributor

Hi,

Thanks for the PR! A couple of things:

  • This does not fix Create a public folder in the scaffold that gets copied as is #322. You need to copy it to dist/; in angular2-app you should add a BroccoliFunnel for it.
  • Please follow the contribution document and retitle this commit as feature: Add public folder
  • Don't put the placeholder in it, please. You could have an empty .gitignore which would be IMO better.

Cheers,

  • Hans

@cwramsey

Copy link
Copy Markdown
Contributor Author

Hey Hans,

Thanks for the suggestions here. I missed the contrib doc, so I'll go check that out now.

@cwramsey cwramsey changed the title Fixes #322 - Adds public folder to ng2 blueprint feature: adds public/ to dist Mar 29, 2016
@cwramsey cwramsey changed the title feature: adds public/ to dist feature: Adds public folder Mar 29, 2016
@cwramsey cwramsey closed this Mar 29, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature Label used to distinguish feature request from other issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants