Skip to content

fix(@angular-devkit/build-angular): show error for missing modules - #14435

Merged
kyliau merged 1 commit into
angular:masterfrom
filipesilva:missing-export-module
May 15, 2019
Merged

kyliau merged 1 commit into
angular:masterfrom
filipesilva:missing-export-module

Conversation

@filipesilva

Copy link
Copy Markdown
Contributor

Fix #14421

@filipesilva
filipesilva requested a review from clydin May 15, 2019 18:48
@filipesilva filipesilva added the target: patch This PR is targeted for the next patch release label May 15, 2019
@filipesilva

Copy link
Copy Markdown
Contributor Author

I'm worried that this change might break projects that currently show warnings for these missing exports.

But #14421 was the first time I even saw this mentioned... if there were projects suffering from this before I expect there would be a lot more reports. For that reason I'm marking it for master and patch instead of just patch.

@kyliau
kyliau merged commit 74f2ee6 into angular:master May 15, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing imports in ESM .js files do not produce errors (only warnings)

4 participants