Skip to content

fix(@schematics/angular): use proper project root for e2e#12494

Merged
alexeagle merged 1 commit intoangular:masterfrom
hansl:fix-12491
Oct 5, 2018
Merged

fix(@schematics/angular): use proper project root for e2e#12494
alexeagle merged 1 commit intoangular:masterfrom
hansl:fix-12491

Conversation

@hansl
Copy link
Copy Markdown
Contributor

@hansl hansl commented Oct 5, 2018

When creating an application, the project root was always "projects/e2e". This
is undesired as it leads to conflicts when creating another app.

Fix #12491.

When creating an application, the project root was always "projects/e2e". This
is undesired as it leads to conflicts when creating another app.

Fix angular#12491.
@hansl hansl requested a review from alan-agius4 October 5, 2018 17:50
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 5, 2018
@alexeagle alexeagle merged commit d1b6e71 into angular:master Oct 5, 2018
@hansl hansl deleted the fix-12491 branch November 28, 2018 23:42
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generating 3rd application to a workspace fails due to an projects/e2e directory collision

4 participants