fix(@angular-devkit/build-angular): resolve assets in styles relative to importee#12437
Merged
alexeagle merged 1 commit intoangular:masterfrom Oct 4, 2018
alan-agius4:fix_assets_import
Merged
fix(@angular-devkit/build-angular): resolve assets in styles relative to importee#12437alexeagle merged 1 commit intoangular:masterfrom alan-agius4:fix_assets_import
alexeagle merged 1 commit intoangular:masterfrom
alan-agius4:fix_assets_import
Conversation
alan-agius4
added
target: major
|
|
clydin
requested changes
Oct 2, 2018
Member
clydin
left a comment
clydin
left a comment
There was a problem hiding this comment.
This works well for CSS files and is a good improvement. Unfortunately, preprocessors internally handle imports for their respective file types making this ineffective in those cases.
| let modified = false; | ||
|
|
||
| // We want to load it relative to the file that imports | ||
| const context = path.dirname(decl.source.input.file) || loader.context; |
Member
There was a problem hiding this comment.
will decl.source.input.file always return a string? If not then path.dirname will throw.
Collaborator
Author
There was a problem hiding this comment.
based on the typings and some tests it should
clydin
previously approved these changes
Oct 2, 2018
… to importee Closes #12430
clydin
approved these changes
Oct 2, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12430