feat(@angular-devkit/build-angular): add --reporters option to test#12404
Merged
alexeagle merged 1 commit intoangular:masterfrom Oct 1, 2018
Merged
feat(@angular-devkit/build-angular): add --reporters option to test#12404alexeagle merged 1 commit intoangular:masterfrom
alexeagle merged 1 commit intoangular:masterfrom
Conversation
clydin
previously approved these changes
Sep 28, 2018
alan-agius4
requested changes
Sep 28, 2018
alan-agius4
reviewed
Sep 28, 2018
| if (options.reporters) { | ||
| // Split along commas to make it more natural, and remove empty strings. | ||
| karmaOptions.reporters = options.reporters | ||
| .reduce<string[]>((acc, curr) => acc.concat(...curr.split(/,/)), []) |
Collaborator
There was a problem hiding this comment.
Is the spread operator really needed here togather with concat?
If you want to use the spread it should be;
[
...acc,
...curr.split(/,/),
]
It was a regression, and used by enough people on CI. No reason it should be omitted and karma.conf.js only. Fixes angular#11376
Contributor
Author
|
@alan-agius4 Done both comments; added to the angular.json schema and removed spread. PTAL. |
alan-agius4
approved these changes
Sep 28, 2018
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
Thanks for the updates. LGTM.
alan-agius4
added
the
target: major
filipesilva
approved these changes
Sep 28, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was a regression, and used by enough people on CI. No reason it should be
omitted and karma.conf.js only.
Fixes #11376