fix(@angular-devkit/build-angular): don't rerun tests on unchanged co…#12402
fix(@angular-devkit/build-angular): don't rerun tests on unchanged co…#12402alexeagle merged 1 commit intoangular:masterfrom
Conversation
filipesilva
added
the
target: major
| it('does not rebuild when nothing changed', (done) => { | ||
| // Start the server in watch mode, wait for the first build to finish, touch | ||
| // test.js without changing it, wait 5s then exit unsuscribe, verify only one event was emitted. | ||
| }, 30000); |
There was a problem hiding this comment.
There's no code in here. is that intentional?
There was a problem hiding this comment.
Yeap, see the comment above. We can't actually test karma in watch mode because there's no way for the karma server to exit gracefully without killing the processes.
There was a problem hiding this comment.
This at least needs a comment, anyone looking at this code later will be very confused why it claims to test something and then doesn't.
Did you think about another way to test this?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
…mpilation
Fix #11880