fix(@angular-devkit/build-angular): add progress option to xi18n#12383
Merged
hansl merged 2 commits intoangular:masterfrom Sep 27, 2018
Merged
fix(@angular-devkit/build-angular): add progress option to xi18n#12383hansl merged 2 commits intoangular:masterfrom
hansl merged 2 commits intoangular:masterfrom
Conversation
Contributor
Author
|
Unfortunately webpack uses process write directly and it's proven impossible to test properly. I tested this manually. There's also no test for the progress option in other packages. |
alan-agius4
requested changes
Sep 27, 2018
Collaborator
There was a problem hiding this comment.
I believe the progress option should also be added here https://github.com/angular/angular-cli/blob/master/packages/angular/cli/lib/config/schema.json#L1079
filipesilva
previously approved these changes
Sep 27, 2018
Contributor
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
LGTM outside of what @alan-agius4 requested.
Add progress option to xi18n. It is passed to the webpack builder. Fixes angular#11667.
Contributor
Author
|
Done. |
filipesilva
approved these changes
Sep 27, 2018
alan-agius4
approved these changes
Sep 27, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add progress option to xi18n. It is passed to the webpack builder.
Fixes #11667.