style: remove redundant async in tests#12380
Merged
hansl merged 2 commits intoangular:masterfrom Sep 27, 2018
alan-agius4:spec_files_schematics
Merged
style: remove redundant async in tests#12380hansl merged 2 commits intoangular:masterfrom alan-agius4:spec_files_schematics
hansl merged 2 commits intoangular:masterfrom
alan-agius4:spec_files_schematics
Conversation
In component specs only the `compileComponents` is async thus the `async` on `it` are redudnant Closes #12161
alan-agius4
added
the
target: patch
hansl
approved these changes
Sep 27, 2018
Contributor
|
This is a breaking change so I'll not merge it in the patch branch. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style: improve formatting of spec file
style: remove redundant async in tests
In component specs only the compileComponents is async thus the async on it are redundant
Closes #12161