fix(@angular-devkit/build-angular): addresses issue were deployUrl#12360
Merged
hansl merged 2 commits intoangular:masterfrom Sep 27, 2018
alan-agius4:fix_deploy_url_serve
Merged
fix(@angular-devkit/build-angular): addresses issue were deployUrl#12360hansl merged 2 commits intoangular:masterfrom alan-agius4:fix_deploy_url_serve
deployUrl#12360hansl merged 2 commits intoangular:masterfrom
alan-agius4:fix_deploy_url_serve
Conversation
alan-agius4
added
target: patch
filipesilva
previously approved these changes
Sep 26, 2018
|
Hi @alan-agius4! This PR has merge conflicts due to recent upstream merges. |
filipesilva
previously approved these changes
Sep 26, 2018
This is due that when targeting an html file, when it doesn't exists it redirects to the root page. So instead use a `js` files to test
…has no effect with serve Closes #11952
hansl
approved these changes
Sep 27, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11952