feat(@ngtools/webpack): add support for traceResolution#12286
feat(@ngtools/webpack): add support for traceResolution#12286hansl merged 1 commit intoangular:masterfrom alan-agius4:fix_trace
traceResolution#12286Conversation
alan-agius4
changed the title
traceResolution now prints module resolutionstraceResolution now prints module resolutions
alan-agius4
added
the
target: patch
| } | ||
|
|
||
| trace(message: string) { | ||
| console.log(message); |
There was a problem hiding this comment.
I don't think we should use console.log for this, but not sure what else we should use. The webpack compilation only allows for warnings and errors, and they show only at the end of the compilation.
@clydin WDYT?
There was a problem hiding this comment.
Just a side note, I don't think you'd want to display the traceResolutions all at the very end, as this is quite verbose. I think it is quite useful to see that output when a module is being resolved.
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
In the original issue I thought this was a bug, but seeing the changes needed I think it's a feature since it changes the output and adds support for something that was not there before.
Can you change the scope please?
|
@filipesilva updated scope as requested. Re the |
alan-agius4
added
target: major
alan-agius4
changed the title
traceResolution now prints module resolutionstraceResolution
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Closes #8676