Skip to content

fix(@angular/cli): fix schema error Property targets is not allowed #12204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansl merged 1 commit into from
Sep 19, 2018
Merged

fix(@angular/cli): fix schema error Property targets is not allowed #12204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions packages/angular/cli/lib/config/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,12 +327,40 @@
"additionalProperties": {
"$ref": "#/definitions/project/definitions/target"
}
},
"targets": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/project/definitions/target"
}
}
},
"required": [
"root",
"projectType"
],
"anyOf": [
{
"required": ["architect"],
"not": {
"required": ["targets"]
}
},
{
"required": ["targets"],
"not": {
"required": ["architect"]
}
},
{
Copy link
Copy Markdown
Collaborator Author

@alan-agius4 alan-agius4 Sep 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because targets and architect are not really required. If they were it could have been something like

"oneOf": [
        {
            "required": ["targets"]
         },
        {
            "required": ["architect"]
        }
]

"not": {
"required": [
"targets",
"architect"
]
}
}
],
"additionalProperties": false,
"patternProperties": {
"^[a-z]{1,3}-.*": {}
Expand Down