fix(@angular/cli): fix schema error Property targets is not allowed#12204
Merged
hansl merged 1 commit intoangular:masterfrom Sep 19, 2018
alan-agius4:fix_schema_cli
Merged
fix(@angular/cli): fix schema error Property targets is not allowed#12204hansl merged 1 commit intoangular:masterfrom alan-agius4:fix_schema_cli
targets is not allowed#12204hansl merged 1 commit intoangular:masterfrom
alan-agius4:fix_schema_cli
Conversation
alan-agius4
added
target: patch
|
|
clydin
requested changes
Sep 7, 2018
| ] | ||
| }, | ||
| "architect": { | ||
| "targets": { |
Member
There was a problem hiding this comment.
either one (but not both at the same time) should be allowed for 7.x. Unfortunately, this makes the schema far more complicated.
alan-agius4
commented
Sep 8, 2018
| "required": ["architect"] | ||
| } | ||
| }, | ||
| { |
Collaborator
Author
There was a problem hiding this comment.
This is because targets and architect are not really required. If they were it could have been something like
"oneOf": [
{
"required": ["targets"]
},
{
"required": ["architect"]
}
]
clydin
approved these changes
Sep 19, 2018
|
|
hansl
approved these changes
Sep 19, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12192