Skip to content

fix(@angular-devkit/schematics): enable sourceMap for coverage mapping#11967

Closed
bitjson wants to merge 1 commit intoangular:masterfrom
bitjson:fix-coverage-source-mapping
Closed

fix(@angular-devkit/schematics): enable sourceMap for coverage mapping#11967
bitjson wants to merge 1 commit intoangular:masterfrom
bitjson:fix-coverage-source-mapping

Conversation

@bitjson
Copy link
Copy Markdown

@bitjson bitjson commented Aug 22, 2018

Fixes #11672

@alan-agius4
Copy link
Copy Markdown
Collaborator

I think in case the sourceMaps are required for correct branches in codeCoverage. This should happen at a Builder level.

When codeCoverage is true and sourceMaps is undefined then sourceMaps are enabled as well

//cc: @hansl what do you think?

@alan-agius4
Copy link
Copy Markdown
Collaborator

Thanks for your PR however this has been super-seeded by #12291

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng test --code-coverage in 6.1 improperly detecting branches

3 participants