Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Update to Bazel 0.20.0 and Angular 7.1.3 - #265

Merged
gregmagolan merged 3 commits into
angular:masterfrom
gregmagolan:bazel-0.20.0
Dec 12, 2018
Merged

Update to Bazel 0.20.0 and Angular 7.1.3#265
gregmagolan merged 3 commits into
angular:masterfrom
gregmagolan:bazel-0.20.0

Conversation

@gregmagolan

@gregmagolan gregmagolan commented Dec 7, 2018

Copy link
Copy Markdown
Contributor

Placeholder PR to update to Bazel 0.20.0.

This is most likely blocked on angular/angular updating to Bazel 0.20.0 first: angular/angular#27394.

Also looks like it depends on an update to rules_go:

ERROR: /private/var/tmp/_bazel_greg/2c2a834fcea131eff2d962ffe20e1c87/external/io_bazel_rules_go/BUILD.bazel:18:1: in go_context_data rule @io_bazel_rules_go//:go_context_data: 
Traceback (most recent call last):
	File "/private/var/tmp/_bazel_greg/2c2a834fcea131eff2d962ffe20e1c87/external/io_bazel_rules_go/BUILD.bazel", line 18
		go_context_data(name = 'go_context_data')
	File "/private/var/tmp/_bazel_greg/2c2a834fcea131eff2d962ffe20e1c87/external/io_bazel_rules_go/go/private/context.bzl", line 310, in _go_context_data
		_filter_options((cpp.compiler_options(features) ...)), ...)
	File "/private/var/tmp/_bazel_greg/2c2a834fcea131eff2d962ffe20e1c87/external/io_bazel_rules_go/go/private/context.bzl", line 311, in _filter_options
		cpp.compiler_options(features)
Information about the C++ toolchain API is not accessible anymore through ctx.fragments.cpp (see --incompatible_disable_legacy_cpp_toolchain_skylark_api on http://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-configuration-api for migration notes). Use CcToolchainInfo instead.

@gregmagolan

gregmagolan commented Dec 7, 2018

Copy link
Copy Markdown
Contributor Author

Includes required change from #256 for http_archive change

@prestonvanloon

prestonvanloon commented Dec 12, 2018

Copy link
Copy Markdown

Is this still blocked?

@gregmagolan gregmagolan changed the title BLOCKED: Update to Bazel 0.20.0 Update to Bazel 0.20.0 and Angular 7.1.3 Dec 12, 2018
@buildsize

buildsize Bot commented Dec 12, 2018 •
edited
Loading

Copy link
Copy Markdown
File name Previous Size New Size Change
bundle.min.js 489 bytes 489 bytes 0 bytes (0%)
hello-world.module.ngfactory.js 12.43 KB 12.59 KB 159 bytes (1%)
hello-world.module.ngfactory.js.map 28.07 KB 28.49 KB 431 bytes (1%)
main.prod.js 22.39 KB 22.39 KB 0 bytes (0%)
main.prod.js.map 45.85 KB 46.11 KB 267 bytes (1%)
todos.module.ngfactory.js 19.02 KB 19.02 KB 0 bytes (0%)
todos.module.ngfactory.js.map 43.98 KB 44.05 KB 70 bytes (0%)
chunk.js 1.64 MB 1.64 MB 2.88 KB (0%)
chunk.js.map 5.27 MB 5.34 MB 67.41 KB (1%)
chunk2.js 15.21 KB 15.21 KB 0 bytes (0%)
chunk2.js.map 44.5 KB 44.5 KB 0 bytes (0%)

alexeagle
alexeagle approved these changes Dec 12, 2018
View reviewed changes
Comment thread WORKSPACE
@gregmagolan gregmagolan mentioned this pull request Dec 12, 2018
Closed
@gregmagolan
gregmagolan merged commit c209b84 into angular:master Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@alexeagle alexeagle alexeagle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@gregmagolan @prestonvanloon @alexeagle