Skip to content

feat(testing): add implicit test module - #9846

Closed
tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:module_test
Closed

feat(testing): add implicit test module#9846
tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:module_test

Conversation

@tbosch

@tbosch tbosch commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@juliemr

juliemr commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

Please update commit message to say that addProviders still works.

@juliemr

juliemr commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

Nevermind, that is only for the compiler.

tbosch
tbosch reviewed Jul 6, 2016
View reviewed changes
Comment thread modules/@angular/core/testing/test_injector.ts Outdated

@tbosch tbosch Jul 6, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this synchronous again. Would only be async if we had built in precompile components in our default platforms, which we never will!

@tbosch tbosch Jul 6, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it sync for now. We can add a special function for async later.

@tbosch tbosch Jul 6, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tbosch tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 6, 2016
tbosch
tbosch reviewed Jul 6, 2016
View reviewed changes
Comment thread modules/@angular/core/testing/test_injector.ts Outdated

@tbosch tbosch Jul 6, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this private

@tbosch tbosch Jul 6, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked as experimental for now.

@juliemr

juliemr commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

cc @vikerman for some changes to testing API.

@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 6, 2016
juliemr
juliemr reviewed Jul 6, 2016
View reviewed changes
Comment thread tools/public_api_guard/core/testing.d.ts Outdated

@juliemr juliemr Jul 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a public typing for the compiler factory, as discussed.

@juliemr

juliemr commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

Please add import statements to the snippets in the BREAKING CHANGE documentation, so we don't have a mysterious 'testingBrowservariable in there. Could you make it havebeforeandaftersections as well for thesetBaseTestProviders` part?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@juliemr juliemr

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbosch @juliemr @googlebot