Repository navigation
fix(common/testing): remove internal MockLocationStrategy from common… - #9562
Merged
Merged
Conversation
juliemr
added
area: testing
Contributor
Author
|
cc @vsavkin this is the change we discussed the common/testing API. Does it look ok? |
juliemr
force-pushed
the
api-review-common
branch
from
June 24, 2016 06:31
0b827a3 to
9c1557d
Compare
juliemr
added
action: review
Contributor
|
is this removed because people should be using mock location rather than mock location strategy? can you please clarify the commit message? |
…/testing BREAKING CHANGE: MockLocationStrategy was intended to be internal only and is now removed from the `@angular/common/testing` public api. Use `SpyLocation` from `@angular/common/testing` for location testing.
juliemr
force-pushed
the
api-review-common
branch
from
June 24, 2016 19:17
9c1557d to
1b33e2a
Compare
Contributor
Author
|
Updated commit message to reflect that users should use SpyLocation if necessary. |
IgorMinar
added
pr_state: LGTM
action: merge
akirasosa
added a commit
to springboot-angular2-tutorial/angular2-app
that referenced
this pull request
Jul 14, 2016
I can not figure out how to use SpyLocation. Though MockLocationStrategy became internal at angular/angular#9562 , SpyLocation still needs LocationStrategy as a constructor parameter. And also, the location strategy provided to SpyLocation is not used at all... https://github.com/angular/angular/blob/master/modules/%40angular/common/testing/location_mock.ts#L33 And also, SpyLocation implements Location, but Location is not an interface... https://github.com/angular/angular/blob/master/modules/%40angular/common/testing/location_mock.ts#L22
ruchirsachdeva
added a commit
to ruchirsachdeva/angular-web-client
that referenced
this pull request
Feb 19, 2017
I can not figure out how to use SpyLocation. Though MockLocationStrategy became internal at angular/angular#9562 , SpyLocation still needs LocationStrategy as a constructor parameter. And also, the location strategy provided to SpyLocation is not used at all... https://github.com/angular/angular/blob/master/modules/%40angular/common/testing/location_mock.ts#L33 And also, SpyLocation implements Location, but Location is not an interface... https://github.com/angular/angular/blob/master/modules/%40angular/common/testing/location_mock.ts#L22
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
MockLocationStrategy was intended to be internal only and is now removed
from the
@angular/common/testingpublic api