Repository navigation
fix(core/testing): move ComponentFixture to core - #9386
Merged
Merged
Conversation
juliemr
commented
Jun 21, 2016
juliemr
commented
Contributor
juliemr
added
area: testing
juliemr
force-pushed
the
component-fixture-move
branch
from
June 21, 2016 05:41
06a1614 to
b8c832b
Compare
Contributor
|
LGTM The commit message can probably says "... will be moving out ... with this release" - because that's what will go into the Changelog. |
Contributor
|
I am not applying the labels before Igor has also reviewed it |
juliemr
force-pushed
the
component-fixture-move
branch
from
June 24, 2016 04:57
b8c832b to
42e28b1
Compare
Contributor
Author
|
I have rebased and changed the commit message to be |
juliemr
changed the title
juliemr
force-pushed
the
component-fixture-move
branch
from
June 24, 2016 05:06
42e28b1 to
0dfc706
Compare
juliemr
force-pushed
the
component-fixture-move
branch
from
June 24, 2016 05:44
0dfc706 to
330f736
Compare
Contributor
There was a problem hiding this comment.
Use -> Import
BREAKING CHANGE: `ComponentFixture` will be moving out of `@angular/compiler/testing` to `@angular/core/testing` in this release. For now, it is deprecated from `@angular/compiler/testing`.
juliemr
force-pushed
the
component-fixture-move
branch
from
June 24, 2016 19:27
330f736 to
3f129bc
Compare
IgorMinar
added
pr_state: LGTM
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.