Repository navigation
Conversation
|
LGTM! 2 Travis jobs are failing on: And another job looks like a pub flake. |
|
@juliemr can you shed some light on this? When exactly is this needed? I thought the new |
|
@PascalPrecht This is for rare situations where you can't use An example would be if you have a |
6511f77 to
4c7b763
Compare
If the async test zone (e.g. `async(inject(...))`) won't work for
your tests, add the option to defer to the Jasmine done function
within inject.
Usage:
```js
it('does stuff', inject([Service, Done], (service, done) {
service.doStuff().whenFinished(done);
}));
```
|
Travis is happy now - adding to merge queue. |
|
Putting this on hold while @vikerman investigates a different method. |
|
FYI - the method we're investigating would look something like: it('does foo', (done) => {
inject([Service}, (service) => {
doStuff();
// sometime later asynchronously
done();
});
}); |
|
Will instead allow use of done and inject with #8257 See particularly example like #8257 (comment) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If the async test zone (e.g.
async(inject(...))) won't work foryour tests, add the option to defer to the Jasmine done function
within inject.
Usage:
Closes #8156