Repository navigation
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
CLAs look good, thanks! |
|
@johan13 thank you! |
|
There's another PR for this if you want to check it out #6944 |
Fix a bug where the Function.prototyp.name shim would return trailing characters for minified functions.
|
What is the status of this PR? Is there something that needs to be improved in order for it to be accepted? |
|
Closing as duplicate of #6944. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR fixes a bug in the
Function.prototype.nameshim inshims_for_IE.js.Without this fix, given a function:
function GetAnswer(){return(42);}the value returned byGetAnswer.nameisGetAnswer(){returninstead ofGetAnswer. This breaks some minified scripts, e.g. ng2-bootstrap's Typeahead component.The new regular expression is copied from the accepted answer to the Stack Overflow question that is mentioned in the source code. The previous regex is from the runner up answer.