Repository navigation
feat(router): Added route name to component instruction - #7667
Closed
brandonroberts wants to merge 1 commit into
Closed
brandonroberts wants to merge 1 commit into
brandonroberts wants to merge 1 commit into
Conversation
Contributor
Author
|
@btford can you review this one? |
brandonroberts
force-pushed
the
component-instruction-route-name
branch
from
March 28, 2016 13:50
e3bd963 to
887cccf
Compare
Contributor
Author
|
Closing in favor of #7834 which adds the route name to the component instruction |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
The component instruction does not include the name provided for the route
Provides the component instruction with the route name. This allows to the user to differentiate between different route names that use the same route component. Also makes it easier to build a breadcrumb component from instructions.
No
Closes #7509
cc: @petebacondarwin @btford