Skip to content

fix(compiler): do not scope nested compound selectors starting with & #71152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rene-schakmann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(compiler): do not scope nested compound selectors starting with & #71152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/compiler/src/shadow_css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,11 @@ export class ShadowCss {
const _scopeSelectorPart = (p: string) => {
let scopedP = p.trim();

if (!scopedP || scopedP === '&') {
// A compound selector starting with `&` (e.g. `&.foo`) only matches elements that are
// already matched by the scoped parent selector so it doesn't need to be scoped again.
// Adding the content attribute would also prevent it from matching when the parent is
// the host element (e.g. `:host { &.foo {} }`), because the host doesn't have it.
if (!scopedP || scopedP.startsWith('&')) {
return p;
}

Expand Down
78 changes: 76 additions & 2 deletions packages/compiler/test/shadow_css/nesting_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ describe('ShadowCss nesting', () => {
.parent[contenta] {
color: blue;

&.modifier[contenta] {
&.modifier {
color: red;
}
}
Expand Down Expand Up @@ -337,6 +337,80 @@ describe('ShadowCss nesting', () => {
expect(result).toEqualCss(expected);
});

it('should not scope compound selectors starting with an ampersand nested in :host', () => {
const css = `
:host {
display: block;

&.modifier {
width: 70px;
}

&:hover, &[disabled] {
color: red;
}
}
`;

const expected = `
[a-host] {
display: block;

&.modifier {
width: 70px;
}

&:hover, &[disabled] {
color: red;
}
}
`;

const result = shim(css, 'contenta', 'a-host');
expect(result).toEqualCss(expected);
});

it('should scope descendants of an ampersand nested in :host', () => {
const css = `
:host {
& .child {
color: red;
}

&.modifier > .child {
color: blue;
}
}
`;

const expected = `
[a-host] {
& .child[contenta] {
color: red;
}

&.modifier > .child[contenta] {
color: blue;
}
}
`;

const result = shim(css, 'contenta', 'a-host');
expect(result).toEqualCss(expected);
});

it('should not scope compound selectors starting with an ampersand nested in :host with a selector', () => {
expect(shim(':host(.foo) { &.bar { color: red; } }', 'contenta', 'a-host')).toEqualCss(
'.foo[a-host] { &.bar { color: red; } }',
);
});

it('should not scope compound selectors starting with an ampersand nested in :host-context', () => {
expect(shim(':host-context(.dark) { &.bar { color: red; } }', 'contenta', 'a-host')).toEqualCss(
'.dark[a-host], .dark [a-host] { &.bar { color: red; } }',
);
});

it('should shim selectors nested in :host-context', () => {
const css = `
:host-context(.foo) {
Expand Down Expand Up @@ -409,7 +483,7 @@ describe('ShadowCss nesting', () => {
color: red;

@media (width >= 1024px) {
&.modifier[contenta] {
&.modifier {
color: blue;
}
}
Expand Down
Loading