Conversation
…rs change The parse error effect in `NgControl.setParseErrorSource()` revalidates the control with `emitEvent: false`, so `statusChanges` never emits and the `markForCheck` subscription set up for custom controls never runs. The control's `errors` input then stays stale under OnPush and zoneless. Mark the view for check from the effect directly. Fixes angular#71127
Member
|
Thanks for the suggestion, but this should be addressed by #71132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The parse error effect in
NgControl.setParseErrorSource()revalidates the control withemitEvent: false, sostatusChangesnever emits and themarkForChecksubscription for custom controls does not run. AFormValueControlusingtransformedValuereceives itserrorsinput one change detection late under OnPush and zoneless.Issue Number: #71127
What is the new behavior?
The effect calls
markForCheck()on the control's view directly, so parse errors reach the control in the same change detection pass. Tests coverngModeland[formControl].Fixes #71127
Does this PR introduce a breaking change?
Other information
Verified with
pnpm bazel test //packages/forms/signals/test/web:test_chromium: the new tests fail without the source change and pass with it.