Conversation
4 of 14 tasks
This updates NgControl to directly evaluate the parseErrors computed signal inside its dynamic validator, rather than waiting for the effect to update a local variable. This allows synchronous validation updates to pick up the fresh parseErrors immediately during setValue, preventing stale states and duplicate valueChanges emissions when the effect runs later. It also retains the ability for independent parseErrors changes to correctly update the control's validity silently. Calling `markForCheck()` ensures the view is updated even when `statusChanges` does not emit. Fixes angular#71127
JeanMeche
force-pushed
the
fix/ng-control-parse-errors
branch
from
October 2, 2026 00:55
11a8ea8 to
7c10993
Compare
JeanMeche
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
NgControlto directly evaluate theparseErrorscomputed signal inside its dynamic validator, rather than waiting for the effect to update a local variable. This allows synchronous validation updates to pick up the freshparseErrorsimmediately duringsetValue, preventing stale states and duplicatevalueChangesemissions when the effect runs later.It also retains the ability for independent
parseErrorschanges to correctly update the control's validity silently. Furthermore, by manually callingmarkForCheck(), it fixes an issue where silent validation changes bypassedstatusChangesand therefore failed to trigger view checks, which prevented control properties from being correctly synced down to the child components.Fixes #71127