Conversation
The previous allowlist only permitted image/*, video/*, and audio/*, which broke internal tests using data:application/octet-stream. Extend the allowlist to include common non-executable MIME types: font/*, application/octet-stream, application/pdf, application/json, text/plain, and text/csv. All executable types (text/html, text/javascript, application/javascript, etc.) remain blocked. This maintains the allowlist architecture (safe by default) while covering legitimate data: URL use cases.
JeanMeche
force-pushed
the
reland-data-attrs
branch
from
September 30, 2026 11:18
c31bdef to
9732747
Compare
JeanMeche
added
the
state: blocked on G3 cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous allowlist only permitted image/, video/, and audio/*, which broke internal tests using data:application/octet-stream.
Extend the allowlist to include common non-executable MIME types: font/*, application/octet-stream, application/pdf, application/json, text/plain, and text/csv. All executable types (text/html, text/javascript, application/javascript, etc.) remain blocked.
This maintains the allowlist architecture (safe by default) while covering legitimate data: URL use cases.
Try to re-land #67692