Conversation
JeanMeche
force-pushed
the
fix-transplanted-views-cleanup
branch
2 times, most recently
from
September 24, 2026 22:48
cd34e80 to
2fc0fbe
Compare
This fixes two issues: 1. Prevents double-detachment bugs where detachView performs redundant DOM manipulation and query detachments on a view that is already destroyed. 2. Ensures the LContainerFlags.HasTransplantedViews flag is cleared when the last transplanted view is detached, preventing unnecessary change detection traversals.
JeanMeche
force-pushed
the
fix-transplanted-views-cleanup
branch
from
September 24, 2026 22:49
2fc0fbe to
d83010b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues with transplanted views during cleanup:
detachViewperforms redundant DOM manipulation and query detachments on a view that is already destroyed.LContainerFlags.HasTransplantedViewsflag is correctly cleared when the last transplanted view is detached, preventing unnecessary change detection traversals.fixes #70923