Skip to content

fix(upgrade): support deferred bootstrap - #7005

Closed
teropa wants to merge 1 commit into
angular:masterfrom
teropa:fix-upgrade-deferred-bootstrap
Closed

fix(upgrade): support deferred bootstrap#7005
teropa wants to merge 1 commit into
angular:masterfrom
teropa:fix-upgrade-deferred-bootstrap

Conversation

@teropa

@teropa teropa commented Feb 11, 2016

Copy link
Copy Markdown
Contributor

Have UpgradeAdapter wait for Angular 1 to bootstrap before running
delayed $applys.

This fixes the use of UpgradeAdapter with Protractor.

Closes #6547

@juliemr

juliemr commented Feb 19, 2016

Copy link
Copy Markdown
Contributor

It would be great to add an e2e test for https://github.com/angular/angular/tree/master/modules/playground/src/upgrade - that would probably belong at modules/playground/e2e_test/upgrade.

@juliemr

juliemr commented Feb 19, 2016

Copy link
Copy Markdown
Contributor

Other than that, LGTM!

@teropa
teropa force-pushed the fix-upgrade-deferred-bootstrap branch 2 times, most recently from 46271c7 to 2993a21 Compare February 22, 2016 07:26
@teropa
fix(upgrade): support deferred bootstrap
4400d88 
Have UpgradeAdapter wait for Angular 1 to bootstrap before running
delayed $applys.

This fixes the use of UpgradeAdapter with Protractor.

Closes angular#6547
@teropa
teropa force-pushed the fix-upgrade-deferred-bootstrap branch from 2993a21 to 4400d88 Compare February 22, 2016 08:31
@teropa

teropa commented Feb 22, 2016

Copy link
Copy Markdown
Contributor Author

Added an E2E test for upgrade, using the existing upgrade playground code.

The failure on Travis looks unrelated to me.

@juliemr

juliemr commented Feb 23, 2016

Copy link
Copy Markdown
Contributor

LGTM, I've seen that Travis error before, it's a flake. I restarted the build.

cc @sjelin who is starting to look into ng-upgrade stuff.

@sjelin

sjelin commented Feb 23, 2016

Copy link
Copy Markdown
Contributor

Thanks @teropa!

@sjelin

sjelin commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

I think this PR is no longer relevant: #7603

@sjelin sjelin closed this Apr 6, 2016
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 8, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

NgUpgrade bootstrap not resolving Ng1 rootScopePrototype when ng1 bootstrap is deferred

5 participants

@teropa @juliemr @sjelin @naomiblack @googlebot