Skip to content

fix(core): Ensure JIT components also use OnPush by default. #69898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeanMeche wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): Ensure JIT components also use OnPush by default. #69898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/metadata/directives.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ export interface Component extends Directive {
*/
export const Component: ComponentDecorator = makeDecorator(
'Component',
(c: Component = {}) => ({changeDetection: ChangeDetectionStrategy.Eager, ...c}),
(c: Component = {}) => ({changeDetection: ChangeDetectionStrategy.OnPush, ...c}),
Directive,
undefined,
(type: Type<any>, meta: Component) => compileComponent(type, meta),
Expand Down
16 changes: 16 additions & 0 deletions packages/core/test/metadata/directives_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/**
* @license
* Copyright Google LLC All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.dev/license
*/

import {ChangeDetectionStrategy, Component} from '@angular/core';

describe('Component decorator', () => {
it('should default changeDetection to OnPush', () => {
const comp = new Component({});
expect(comp.changeDetection).toBe(ChangeDetectionStrategy.OnPush);
});
});
14 changes: 14 additions & 0 deletions packages/core/test/test_bed_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,20 @@ describe('TestBed with Standalone types', () => {
expect(hostElement.textContent).toBe('transformed original value using Overridden A token');
});

it('should preserve default change detection when overriding components', () => {
@Component({
template: 'Original',
})
class DefaultCmp {}

const onPushBefore = (DefaultCmp as any).ɵcmp.onPush;
TestBed.overrideComponent(DefaultCmp, {set: {template: 'Overridden'}});
TestBed.createComponent(DefaultCmp);
const onPushAfter = (DefaultCmp as any).ɵcmp.onPush;

expect(onPushAfter).withContext('ɵcmp.OnPush after override').toBe(onPushBefore);
});

describe('NgModules as dependencies', () => {
@Component({
selector: 'test-cmp',
Expand Down