fix(compiler): scope nested CSS rules - #69885
Merged
Merged
Conversation
crisbeto
added
action: review
angular-robot
Bot
added
the
area: compiler
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jul 27, 2026
Adds some temporary logic to strip `::ng-deep` from nested selectors which will help us land angular#69885.
crisbeto
force-pushed
the
nested-css-again
branch
2 times, most recently
from
August 3, 2026 14:57
369bd13 to
747233b
Compare
Member
Author
|
Passing TGP after we land some client fixes. |
crisbeto
added
target: minor
crisbeto
marked this pull request as ready for review
August 3, 2026 15:01
mattrbeck
reviewed
Aug 4, 2026
crisbeto
force-pushed
the
nested-css-again
branch
from
August 4, 2026 09:08
747233b to
5cea734
Compare
Member
Author
|
Fresh passing TGP that includes the latest code changes and the client fixes. |
mattrbeck
reviewed
Aug 5, 2026
This is a second attempt at scoping nested CSS rules after not being able to land angular#50693. I took some extra precautions to try and avoid the crash that was happening last time.
… ::ng-deep
Updates the nested selector encapsulation logic so that it skips encapsulating child selectors if the parent contains `::ng-deep`. The reasoning is that `:host ::ng-deep { .foo {} }` should behave as `:host ::ng-deep .foo {}`.
Adds a test to cover the case where an `@import` might have a URL with special characters that isn't quoted.
crisbeto
force-pushed
the
nested-css-again
branch
from
August 5, 2026 10:53
5cea734 to
879d4f1
Compare
mattrbeck
approved these changes
Aug 5, 2026
crisbeto
added
action: merge
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This was referenced Sep 27, 2026
This was referenced Sep 29, 2026
4 of 5 tasks
4 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second attempt at scoping nested CSS rules after not being able to land #50693. I took some extra precautions to try and avoid the crash that was happening last time.