Conversation
|
We can't land a feat commit in a patch version. Wdyt of making the change a refactor ? |
alan-agius4
left a comment
There was a problem hiding this comment.
Which use-cases / issues are we fixing with these changes?
@alan-agius4 The second fix addresses the issue of the new properties not being properly tested because |
…ponse Fixes omission of redirected and responseType from the Fetch API in HttpErrorResponse when the promise fails or when an error occurs while parsing the response body.
… and testing Store Fetch API redirected and responseType metadata in the HTTP transfer cache when present, so hydrated HttpResponse instances retain the same values. These fields remain omitted for XHR-based responses where the values are not available. Extend TestRequest.flush() and TestRequest.error() so HttpTestingController tests can provide redirected and responseType on mock responses.
ffd4d7a to
ae370b6
Compare
…r cache and testing
|
Thanks for working on this! After reviewing the changes and the use cases:
Since there isn't a compelling use case that justifies the additional transfer state payload and complexity, I'm going to close this PR. Thanks again for your contribution! |
fix(http): handle missing redirected and responseType in HttpErrorResponse
Fixes omission of redirected and responseType from the Fetch API in HttpErrorResponse when the promise fails or when an error occurs while parsing the response body.
refactor(http): support redirected and responseType in transfer cache and testing
Store Fetch API redirected and responseType metadata in the HTTP transfer cache when present, so hydrated HttpResponse instances retain the same values. These fields remain omitted for XHR-based responses where the values are not available.
Extend TestRequest.flush() and TestRequest.error() so HttpTestingController tests can provide redirected and responseType on mock responses.