Repository navigation
fix(IE): make shim work with instrumented code - #6944
justindujardin wants to merge 1 commit into
Conversation
justindujardin
commented
Feb 8, 2016
- the function name patch from stack overflow has a regexp that is too liberal.
- related to Unable to view AngularJS 2.0 Beta 1 in Internet Explorer: The use of a keyword for an identifier is invalid #6501
|
This breaks some tests in IE10 and IE9: https://travis-ci.org/angular/angular/jobs/107675986 |
1fdb099 to
3122b1d
Compare
3122b1d to
7ca199b
Compare
7ca199b to
da7c802
Compare
|
@Mlaval Sorry this took so long, the CI build failed last time for some unknown reason, and I've been busy at work. All green now. |
|
👍 Please don't hold this fix back, since it's needed and does not depend on fixing the "bigger" issues that refers it. Also, please include note in CHANGELOG so that people can remove their own workaround when upgrading angular. |
|
I realize I have created a duplicate pull request (#7864). Sorry. Anyway, I think the regex suggested in this PR is too restrictive. ECMAScript identifiers are not limited to basic ASCII characters: http://www.ecma-international.org/ecma-262/6.0/index.html#sec-identifier-names The specification is kind of hard to read, but I tried creating a function in Google Chrome that looked like this I suggest we use the simpler regex from my PR. |
|
For me, this fixed the exception reported in #7632 as well, which ist still marked as open. But I am not sure, if this is generally the case. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |