Skip to content

fix(IE): make shim work with instrumented code - #6944

Closed
justindujardin wants to merge 1 commit into
angular:masterfrom
justindujardin:patch-1
Closed

justindujardin wants to merge 1 commit into
angular:masterfrom
justindujardin:patch-1

Conversation

@justindujardin

Copy link
Copy Markdown
Contributor

@marclaval marclaval added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 8, 2016
@marclaval

Copy link
Copy Markdown
Contributor

This breaks some tests in IE10 and IE9: https://travis-ci.org/angular/angular/jobs/107675986
Can you fix please?

@justindujardin

Copy link
Copy Markdown
Contributor Author

@Mlaval Sorry this took so long, the CI build failed last time for some unknown reason, and I've been busy at work. All green now.

@jesperronn

Copy link
Copy Markdown
Contributor

👍 Please don't hold this fix back, since it's needed and does not depend on fixing the "bigger" issues that refers it.

Also, please include note in CHANGELOG so that people can remove their own workaround when upgrading angular.

@johan13

johan13 commented Apr 1, 2016

Copy link
Copy Markdown

I realize I have created a duplicate pull request (#7864). Sorry.

Anyway, I think the regex suggested in this PR is too restrictive. ECMAScript identifiers are not limited to basic ASCII characters: http://www.ecma-international.org/ecma-262/6.0/index.html#sec-identifier-names

The specification is kind of hard to read, but I tried creating a function in Google Chrome that looked like this function HallåDär() { console.log("Hej!"); } and it worked fine.

I suggest we use the simpler regex from my PR.

@stefanocke

Copy link
Copy Markdown

For me, this fixed the exception reported in #7632 as well, which ist still marked as open. But I am not sure, if this is generally the case.

KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 10, 2016
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
@justindujardin
justindujardin deleted the patch-1 branch September 9, 2019 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants