Skip to content

fix(router): queue rejections in firstValueFrom to avoid unhandled rejections #66542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arturovt wants to merge 1 commit into from
Closed

fix(router): queue rejections in firstValueFrom to avoid unhandled rejections #66542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/router/src/utils/first_value_from.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,18 @@ export function firstValueFrom<T>(source: Observable<T>): Promise<T> {
return new Promise<T>((resolve, reject) => {
source.pipe(first()).subscribe({
next: (value) => resolve(value),
error: (err) => reject(err),
// Issue: When an observable completes without emitting, the `first()` operator
// throws `EmptyError` synchronously. This causes the promise
// to reject synchronously, before the caller can attach a `.catch()` handler. Zone.js
// detects this as an unhandled rejection and logs/re-throws the error, even though
// the caller does properly handle it with `.catch()` or try-catch.
//
// Defer the rejection by one microtask using `queueMicrotask()`. This ensures
// the caller's `.catch()` handler is attached before the rejection occurs, satisfying
// zone.js's unhandled rejection detection.
//
// This change becomes obsolete when Angular entirely drops zone.js support.
error: (err) => queueMicrotask(() => reject(err)),
});
});
}