Conversation
This fixes a bug introduced in angular#63485 where `firstValueFrom` was used. This doesn't work in all situations here because some observables don't emit before completing. These errors should result in the route matching logic moving on to the next route. Note: This is marked as a refactor rather than fix because the commit above is not in any release yet.
atscott
added
the
merge: caretaker note
Contributor
Author
|
caretaker note: This path is not used in g3 yet so presubmit won't be useful |
mmalerba
approved these changes
Sep 2, 2025
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #63485 where
firstValueFromwas used. This doesn't work in all situations here because some observables don't emit before completing. These errors should result in the route matching logic moving on to the next route.Note: This is marked as a refactor rather than fix because the commit above is not in any release yet.