Conversation
mmalerba
approved these changes
Aug 29, 2025
atscott
force-pushed
the
firstvaluefrom
branch
from
August 29, 2025 16:41
7a53115 to
64cc0d4
Compare
This fixes a bug introduced in angular#62994 where `toPromise` was used. This doesn't work in all situations here because some observables don't complete. This only affected the redirect path, since the others are already behind other rxjs code which takes the first value from the user guards. Note: This is marked as a refactor rather than fix because the commit above is not in any release yet.
atscott
force-pushed
the
firstvaluefrom
branch
from
August 29, 2025 16:47
64cc0d4 to
6a0e477
Compare
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
atscott
added a commit
to atscott/angular
that referenced
this pull request
Sep 2, 2025
This fixes a bug introduced in angular#63485 where `firstValueFrom` was used. This doesn't work in all situations here because some observables don't emit before completing. These errors should result in the route matching logic moving on to the next route. Note: This is marked as a refactor rather than fix because the commit above is not in any release yet.
mmalerba
pushed a commit
that referenced
this pull request
Sep 2, 2025
This fixes a bug introduced in #63485 where `firstValueFrom` was used. This doesn't work in all situations here because some observables don't emit before completing. These errors should result in the route matching logic moving on to the next route. Note: This is marked as a refactor rather than fix because the commit above is not in any release yet. PR Close #63546
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #62994 where
toPromisewas used. This doesn't work in all situations here because some observables don't complete. This only affected the redirect path, since the others are already behind other rxjs code which takes the first value from the user guards.Note: This is marked as a refactor rather than fix because the commit above is not in any release yet.