Skip to content

build(node): split test and src compilation units - #6262

Closed
vicb wants to merge 1 commit into
angular:masterfrom
vicb:1222-compileUnits
Closed

build(node): split test and src compilation units#6262
vicb wants to merge 1 commit into
angular:masterfrom
vicb:1222-compileUnits

Conversation

@vicb

@vicb vicb commented Jan 4, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@vicb
vicb force-pushed the 1222-compileUnits branch from ff41e1e to 82dcd9e Compare January 6, 2016 00:02
@vicb vicb mentioned this pull request Jan 6, 2016
Closed
@vicb

vicb commented Jan 6, 2016

Copy link
Copy Markdown
Contributor Author

@IgorMinar could you please review.

On my machine:

  • build.js.cjs went from ~8 to ~11s,
  • test.js.cjs went from ~3 to ~4s on file change

@vicb vicb added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 6, 2016
@vicb vicb changed the title [WIP] build(node): split test and src compilation units build(node): split test and src compilation units Jan 6, 2016
@vicb
vicb force-pushed the 1222-compileUnits branch 3 times, most recently from 0fcf35a to bf18b9b Compare January 7, 2016 00:51
@IgorMinar IgorMinar added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 19, 2016
@mary-poppins

mary-poppins commented Jan 19, 2016

Copy link
Copy Markdown

Merging PR #6262 on behalf of @jeffbcross to branch presubmit-jeffbcross-pr-6262.

@jeffbcross jeffbcross assigned jeffbcross and unassigned IgorMinar Jan 19, 2016
@vicb
vicb force-pushed the 1222-compileUnits branch from bf18b9b to f06e500 Compare January 19, 2016 23:38
@vicb
vicb force-pushed the 1222-compileUnits branch from f06e500 to 54d8488 Compare January 19, 2016 23:51
@vicb

vicb commented Jan 20, 2016

Copy link
Copy Markdown
Contributor Author

Closed via #6581

@vicb vicb closed this Jan 20, 2016
@IgorMinar IgorMinar mentioned this pull request Jan 22, 2016
Closed
@vicb
vicb deleted the 1222-compileUnits branch June 23, 2016 17:43
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 8, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

5 participants

@vicb @mary-poppins @IgorMinar @jeffbcross @googlebot